paplayer: avoid blocking in OpenFile, call QueueNextFile instead #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please i know you are bored |
|
Would this not mean we lose the crossfade on twin streams thing completely as this is now non-blocking, so m_streams.size() will rarely be 2 (the job is unlikely to get very far along) ? |
|
ah ok. it won't interrupt the playing stream any more. this needs another iteration ... |
|
@jmarshallnz updated. only changes behavior if AE is suspended |
|
Is it obvious to the paplayer devs (assuming they exist) as to why it should be different, or is a comment in the code required? |
|
a comment is always a good idea, will update |
|
jenkins build this please |
3 similar comments
|
jenkins build this please |
|
jenkins build this please |
|
jenkins build this please |
jmarshallnz
added a commit
that referenced
this pull request
Mar 8, 2014
paplayer: avoid blocking in OpenFile, call QueueNextFile instead
jmarshallnz
added a commit
that referenced
this pull request
Mar 9, 2014
paplayer: avoid blocking in OpenFile, call QueueNextFile instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes http://trac.xbmc.org/ticket/14987
Mainthread can't be blocked by MakeStream while AE waits for OnDisplayReset event.